Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-dock package potentially "bloated" with types in dependencies instead of devDependencies #1392

Closed
nathanmmiller opened this issue Apr 11, 2023 · 2 comments

Comments

@nathanmmiller
Copy link

Is there a good reason why react-dock has @types packages in dependencies rather than devDependencies?

The impact is that it swells package.json when using yarn1 and explicitly including the same @types packages in devDependencies in a project, even with flexible versioning.

I'm happy to raise a PR to fix this if there's not a valid reason for it.

@Methuselah96
Copy link
Member

It is intentional. When a library's declaration files depend on the types from a certain package then the types package needs to go in dependencies, not devDependencies (1) (2).

@nathanmmiller nathanmmiller closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
@nathanmmiller
Copy link
Author

Ok then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants