You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a good reason why react-dock has @types packages in dependencies rather than devDependencies?
The impact is that it swells package.json when using yarn1 and explicitly including the same @types packages in devDependencies in a project, even with flexible versioning.
I'm happy to raise a PR to fix this if there's not a valid reason for it.
The text was updated successfully, but these errors were encountered:
It is intentional. When a library's declaration files depend on the types from a certain package then the types package needs to go in dependencies, not devDependencies (1) (2).
Is there a good reason why react-dock has @types packages in dependencies rather than devDependencies?
The impact is that it swells package.json when using yarn1 and explicitly including the same @types packages in devDependencies in a project, even with flexible versioning.
I'm happy to raise a PR to fix this if there's not a valid reason for it.
The text was updated successfully, but these errors were encountered: