Migrate code to Kotlin Multiplatform #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gradle 8.7 - create convention plugins - add gradle.properties, enable build cache, config cache - simplify some build logic (e.g. sources jar)
- replace JUnit test Kotlin Test - replace Apache utils with custom implementations - improve reflection check and test - disable ktlint, because it complains about import order, which is determined by IntelliJ and I can't modify it. Annoying!
- Split XML parsing into `XmlParse.kt` (because it uses JVM specific code). - Rename tests (JS doesn't support spaces in names). - Create a Gradle task for generating code to access test results in commonTest (KMP doesn't have a built-in way of accessing resources.) WIP: need to fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR that implements Kotlin Multiplatform support
Fix #57
TODO
assertEquals()on some elements.Depends on