From 36b01f432baee56e8d2558286e3d8c383948ae00 Mon Sep 17 00:00:00 2001 From: NyaliaLui Date: Fri, 9 Jun 2023 09:32:21 -0400 Subject: [PATCH 1/2] k/proto: use log-level warn for missmatch crc It was revealed that upstream kafka will ignore this error. Therefore, RP should not log it at a high severity. Fixes #6631 Fixes #10169 --- src/v/kafka/protocol/kafka_batch_adapter.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v/kafka/protocol/kafka_batch_adapter.cc b/src/v/kafka/protocol/kafka_batch_adapter.cc index 90f6a0914d9f..567fd7af8dc0 100644 --- a/src/v/kafka/protocol/kafka_batch_adapter.cc +++ b/src/v/kafka/protocol/kafka_batch_adapter.cc @@ -123,7 +123,7 @@ void kafka_batch_adapter::verify_crc(int32_t expected_crc, iobuf_parser in) { if (unlikely((uint32_t)expected_crc != crc.value())) { valid_crc = false; vlog( - klog.error, + klog.warn, "Cannot validate Kafka record batch. Missmatching CRC. Expected:{}, " "Got:{}", expected_crc, From 41d7317aa55800b909dbf8007dd00cd2e1113c04 Mon Sep 17 00:00:00 2001 From: NyaliaLui Date: Fri, 9 Jun 2023 09:48:37 -0400 Subject: [PATCH 2/2] tests/cloud: remove missmatch CRC from allow list --- .../rptest/scale_tests/cloud_storage_compaction_test.py | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tests/rptest/scale_tests/cloud_storage_compaction_test.py b/tests/rptest/scale_tests/cloud_storage_compaction_test.py index bc90c152e62f..0a4955952b9b 100644 --- a/tests/rptest/scale_tests/cloud_storage_compaction_test.py +++ b/tests/rptest/scale_tests/cloud_storage_compaction_test.py @@ -162,14 +162,7 @@ def _setup_read_replica(self): timeout_sec=30, backoff_sec=5) - # Permit transient CRC errors, to protect this test from incidences of - # https://github.com/redpanda-data/redpanda/issues/6631 - # TODO: remove this low allow-list when that issue is resolved. - @cluster(num_nodes=9, - log_allow_list=[ - "Cannot validate Kafka record batch. Missmatching CRC", - "batch has invalid CRC" - ]) + @cluster(num_nodes=9) @matrix( cloud_storage_type=get_cloud_storage_type(docker_use_arbitrary=True)) def test_read_from_replica(self, cloud_storage_type):