Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a cpuset for sharded alien threads #13090

Closed
rockwotj opened this issue Aug 30, 2023 · 2 comments
Closed

Consider using a cpuset for sharded alien threads #13090

rockwotj opened this issue Aug 30, 2023 · 2 comments

Comments

@rockwotj
Copy link
Contributor

rockwotj commented Aug 30, 2023

did you consider passing in a cpuset here? that could allow us more flexibility, for example, arranging for all the alien threads to run on dedicated cores, like here:

https://github.com/ceph/ceph/blob/20398601e76a6ff48b3886d10cffdceb68fcafcb/src/crimson/os/alienstore/alien_store.cc#L105-L119

it'd be a minor change in the future, so i don't think it's necessary right now. the more i think about the more a dedicated core(s) makes a lot of sense. communicating through shared memory is cheap but when we pin the transform to a reactor core we have to context switch and suspend the reactor.

Originally posted by @dotnwat in #13056 (comment)

JIRA Link: CORE-1420

@emaxerrno
Copy link
Contributor

woah!!! this is an awesome idea! haha. clever. Didn't occur to me to have this...

you can now have M:N models woah 🤯 - makes total sense. @rockwotj we should add.

great observation @dotnwat

@rockwotj rockwotj closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@rockwotj
Copy link
Contributor Author

We didn't use alien threads for wasm so closing as obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants