Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the refresh button sometimes doesn't change it into "loading state" #75

Closed
rikimaru0345 opened this issue Jul 22, 2020 · 2 comments
Assignees
Labels
bug Something isn't working frontend

Comments

@rikimaru0345
Copy link
Contributor

As the title says.
Also ConsumerGroupDetails does not seem to actually refresh any data (lag values stay the same, but in TopicDetails it works).

@rikimaru0345 rikimaru0345 added bug Something isn't working frontend labels Jul 22, 2020
@rikimaru0345 rikimaru0345 added this to the 1.1 release milestone Jul 22, 2020
@rikimaru0345 rikimaru0345 self-assigned this Jul 22, 2020
@rikimaru0345
Copy link
Contributor Author

rikimaru0345 commented Jul 22, 2020

root issue is:
the code that decides whether or not to show the loading indicator is pretty old and based on a periodic check (i know, wtf 😅).

solution:
keep track of the number of currently running requests (as an observable number).

rest requests should always cause the the indicator to show.
and the indicator should show for some minimum time (300ms?) even if the request completes much more quickly.

@rikimaru0345
Copy link
Contributor Author

fixed in 9a239a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

1 participant