Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bq: fix inverted err #3071

Merged
merged 1 commit into from
Dec 10, 2024
+11 −2
Merged

bq: fix inverted err #3071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ Changelog

All notable changes to this project will be documented in this file.

## 4.44.0 - TBD

### Fixed

- `gcp_bigquery` output with parquet format no longer returns errors incorrectly. (@rockwotj)

## 4.43.1 - 2024-12-09

### Fixed
Expand Down
7 changes: 5 additions & 2 deletions internal/impl/gcp/output_bigquery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,15 +421,18 @@ func (g *gcpBigQueryOutput) WriteBatch(ctx context.Context, batch service.Messag
}
for idx, job := range jobs {
status, err := job.Wait(ctx)
if err == nil {
if err != nil {
setErr(idx, fmt.Errorf("error while waiting on bigquery job: %w", err))
continue
}
if err = errorFromStatus(status); err != nil {
setErr(idx, err)
}
}
return batchErr
if batchErr != nil {
return batchErr
}
return nil
}

var data bytes.Buffer
Expand Down
Loading