Skip to content

Commit

Permalink
bq: fix inverted err
Browse files Browse the repository at this point in the history
  • Loading branch information
rockwotj committed Dec 10, 2024
1 parent 82bfecb commit 5073eb6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ Changelog

All notable changes to this project will be documented in this file.

## 4.44.0 - TBD

### Fixed

- `gcp_bigquery` output with parquet format no longer returns errors incorrectly. (@rockwotj)

## 4.43.1 - 2024-12-09

### Fixed
Expand Down
7 changes: 5 additions & 2 deletions internal/impl/gcp/output_bigquery.go
Original file line number Diff line number Diff line change
Expand Up @@ -421,15 +421,18 @@ func (g *gcpBigQueryOutput) WriteBatch(ctx context.Context, batch service.Messag
}
for idx, job := range jobs {
status, err := job.Wait(ctx)
if err == nil {
if err != nil {
setErr(idx, fmt.Errorf("error while waiting on bigquery job: %w", err))
continue
}
if err = errorFromStatus(status); err != nil {
setErr(idx, err)
}
}
return batchErr
if batchErr != nil {
return batchErr
}
return nil
}

var data bytes.Buffer
Expand Down

0 comments on commit 5073eb6

Please sign in to comment.