bq: fix inverted err

redpanda-data · Dec 10, 2024 · 2c5e71d · 2c5e71d
1 parent 82bfecb
commit 2c5e71d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,12 @@ Changelog
 
 All notable changes to this project will be documented in this file.
 
+## 4.44.0 - TBD
+
+### Fixed
+
+- `gcp_bigquery` output with parquet format no longer returns errors incorrectly. (@rockwotj)
+
 ## 4.43.1 - 2024-12-09
 
 ### Fixed

diff --git a/internal/impl/gcp/output_bigquery.go b/internal/impl/gcp/output_bigquery.go
@@ -421,7 +421,7 @@ func (g *gcpBigQueryOutput) WriteBatch(ctx context.Context, batch service.Messag
 		}
 		for idx, job := range jobs {
 			status, err := job.Wait(ctx)
-			if err == nil {
+			if err != nil {
 				setErr(idx, fmt.Errorf("error while waiting on bigquery job: %w", err))
 				continue
 			}