Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo predicate with url #388

Merged
merged 3 commits into from
Jul 22, 2022
Merged

fix: typo predicate with url #388

merged 3 commits into from
Jul 22, 2022

Conversation

redouane59
Copy link
Owner

@redouane59 redouane59 commented Jul 22, 2022

Fixing #387

@gitguardian
Copy link

gitguardian bot commented Jul 22, 2022

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4020888 Generic High Entropy Secret 107d0e0 test-twitter-credentials.json View secret
4020889 Generic High Entropy Secret 107d0e0 test-twitter-credentials.json View secret
4020890 Generic High Entropy Secret 107d0e0 test-twitter-credentials.json View secret
4020891 Generic High Entropy Secret 107d0e0 test-twitter-credentials.json View secret
4020888 Generic High Entropy Secret 8eeb0fd test-twitter-credentials.json View secret
4020889 Generic High Entropy Secret 8eeb0fd test-twitter-credentials.json View secret
4020890 Generic High Entropy Secret 8eeb0fd test-twitter-credentials.json View secret
4020891 Generic High Entropy Secret 8eeb0fd test-twitter-credentials.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@redouane59 redouane59 marked this pull request as ready for review July 22, 2022 08:39
@redouane59 redouane59 merged commit 98d41a5 into develop Jul 22, 2022
@redouane59 redouane59 deleted the fix_typo_predicate branch July 22, 2022 08:40
@redouane59 redouane59 mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant