Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user objects in TweetList data #336

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

redouane59
Copy link
Owner

Solving #335

@gitguardian
Copy link

gitguardian bot commented Dec 5, 2021

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret 54f9ec0 src/test/resources/tests/tweet_list_v2_search_lab_example.json 10:21 December 5th, 2021 View secret
Generic High Entropy Secret 54f9ec0 src/test/resources/tests/tweetlist_example_v2.json 10:21 December 5th, 2021 View secret
🛠 How to resolve this
  1. Understand the implications of revoking this secret by examining where it is used in your code.

  2. Replace and store your secret safely. Learn here the best practices

  3. Revoke and rotate this secret

  4. If possible, rewrite your git history to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

💡 To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

96.3% 96.3% Coverage
0.0% 0.0% Duplication

@redouane59 redouane59 merged commit c8b5f34 into develop Dec 5, 2021
@redouane59 redouane59 deleted the feat_add_user_objcts_in_tweetlist_tweets branch December 5, 2021 11:06
@redouane59 redouane59 mentioned this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant