Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all assumptions about default branch names #168

Open
LinuxMercedes opened this issue Sep 2, 2021 · 1 comment
Open

Remove all assumptions about default branch names #168

LinuxMercedes opened this issue Sep 2, 2021 · 1 comment

Comments

@LinuxMercedes
Copy link
Member

Assigner hails from the days when hardwiring "master" as the default branch name made sense, but that is fortunately no longer the case. We should be able to fetch the default branch from Gitlab.

Questions:

  • Should we check the default branch for each repo, or assume that student repos use the same default branch as the template repo they're made from?

Docs:

@BehindTheBrain
Copy link

I implemented and checked this task.
All branch name assumptions were removed.
I think that explicit is better than implicit default detection.
Thus, in this fork, --branch is required for a specified set of sub-commands.

https://github.com/BehindTheBrain/assigner

Going forward, I will likely tend to simplify and remove complexity, rather than add non-critical features.
So, whether I maintain a separate fork, or take over as a maintainer, is up to y'all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants