Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL encoded parameters in Redis URLs by Default #589

Closed
paulkeene opened this issue Feb 10, 2015 · 4 comments
Closed

Allow URL encoded parameters in Redis URLs by Default #589

paulkeene opened this issue Feb 10, 2015 · 4 comments
Labels

Comments

@paulkeene
Copy link
Contributor

Yesterday I submitted pull request #586 to allow URL encoded parameters to be included in Redis URLs, but this has to be explicitly enabled by passing decode_components=True to from_url since existing clients might be relying on the current behavior.

I saw that version 3.0 of redis-py is in the works so it might be nice to include a change in the new version that removes the decode_components argument and always decodes URL components.

@andymccurdy
Copy link
Contributor

Agreed. I believe the only issue with making this the default behavior currently is passwords that have a "%" in them.

@gyermolenko
Copy link
Contributor

Since v3.0 has happened in 2018 maybe this issue can be revisited.
v4 label or wont-fix/close maybe?

@github-actions
Copy link
Contributor

This issue is marked stale. It will be closed in 30 days if it is not updated.

@andymccurdy
Copy link
Contributor

This is now the default and will be included in the 4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants