Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about large transactions #738

Closed
hookumsnivy opened this issue Mar 21, 2018 · 2 comments
Closed

Question about large transactions #738

hookumsnivy opened this issue Mar 21, 2018 · 2 comments
Labels
for: stackoverflow A question that is better suited to stackoverflow.com status: duplicate A duplicate of another issue status: waiting-for-feedback We need additional information before we can continue

Comments

@hookumsnivy
Copy link

hookumsnivy commented Mar 21, 2018

I'm using 5.0.2.RELEASE and processing large transactions - approximately 200k hsets.
I'm not interacting with lettuce directly, but instead through Spring Boot 2.0.0 and Spring Redis Data 2.0.5. Both were recent upgrades and I was using jedis in the past without a problem.
I'm not familiar with Lettuce at all, so please forgive my lack of understanding if I say something wrong.

Committing the transaction takes an abnormally long time (I haven't let it finish) and only the MULTI command has been written to Redis before I kill the process. I've stepped through the code and I think I may have found the culprit:

The addToStack method in CommandHandler. Before adding the command to the stack, it is checking to see if the command is already in the stack. This operation gets more and more expensive each time a command is added as it has to iterate through the entire stack each time.
Is this expected?
Is it necessary to make sure there aren't duplicates?

@mp911de
Copy link
Collaborator

mp911de commented Mar 22, 2018

This issue was addressed with #709 and the fixed version is available as snapshot build 5.0.3.BUILD-SNAPSHOT. Care to upgrade and give the fix a try?

@mp911de mp911de added status: duplicate A duplicate of another issue for: stackoverflow A question that is better suited to stackoverflow.com status: waiting-for-feedback We need additional information before we can continue labels Mar 22, 2018
@mp911de
Copy link
Collaborator

mp911de commented Apr 3, 2018

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@mp911de mp911de closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: stackoverflow A question that is better suited to stackoverflow.com status: duplicate A duplicate of another issue status: waiting-for-feedback We need additional information before we can continue
Projects
None yet
Development

No branches or pull requests

2 participants