Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test shouldNotEmitEventForAbsentJfrEventType Failed #3066

Open
XuexuanWang opened this issue Dec 2, 2024 · 3 comments
Open

Unit test shouldNotEmitEventForAbsentJfrEventType Failed #3066

XuexuanWang opened this issue Dec 2, 2024 · 3 comments
Labels
status: help-wanted An issue that a contributor can help us with type: bug A general bug type: regression A regression from a previous release

Comments

@XuexuanWang
Copy link

Bug Report

Current Behavior

The unit test shouldNotEmitEventForAbsentJfrEventType() in the class JfrEventRecorderUnitTests failed.
The expecting value was false but somehow it returned true. While debugging, I noticed that the createEvent() was called, is this the expected behavior? Thank you!

org.opentest4j.AssertionFailedError:
Expecting value to be false but was true
Expected :false
Actual :true

Environment

  • Lettuce version(s): 6.2.2 RELEASE (Also failed in 6.5.0 RELEASE)
  • Redis version: N/A
@tishun tishun added type: bug A general bug type: regression A regression from a previous release labels Dec 2, 2024
@tishun
Copy link
Collaborator

tishun commented Dec 2, 2024

@XuexuanWang priority-wise how important is this for you right now?

@XuexuanWang
Copy link
Author

Hi @tishun, thanks for replying!
It's not urgent, just want to understand the reason for the failure.

@tishun
Copy link
Collaborator

tishun commented Dec 4, 2024

Hi @tishun, thanks for replying! It's not urgent, just want to understand the reason for the failure.

Needs some investigation.

These tests were omitted (I'd say not intentionally) from the pipeline and it seems they have stopped working at some point. I will leave this open so we can investigate when we have some time, but for now I am treating it as low priority.

If the community would like to spend some time on that PRs are - as always - welcome.

@tishun tishun added the status: help-wanted An issue that a contributor can help us with label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help-wanted An issue that a contributor can help us with type: bug A general bug type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

2 participants