Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the downside of disabling JFR #2334

Closed
asadyarkhan007 opened this issue Feb 17, 2023 · 1 comment
Closed

What are the downside of disabling JFR #2334

asadyarkhan007 opened this issue Feb 17, 2023 · 1 comment
Labels
for: stackoverflow A question that is better suited to stackoverflow.com

Comments

@asadyarkhan007
Copy link

asadyarkhan007 commented Feb 17, 2023

We are running AppD in our pod along with our application. Our application use lettuce library for redis connectivity, for some reason, When we upgraded our lettuce library version to 6.1.3 in the application then we start getting error: Could not initialize JfrConnectionCreatedEvent #1767.
So we found following link and tried to resolved:
#1767
Based on above link there are two solutions:

  1. Use the following statement System.getProperty("io.lettuce.core.jfr",false); to disable the jfr.
  2. The second is to provide --add-reads=jdk.jfr=ALL-UNNAMED on jvm argument.

Could you guys tell me which one is better approach and what is the downside of disabling the JFR in lettuce?

@mp911de
Copy link
Collaborator

mp911de commented Feb 20, 2023

JFR events make sense if you use these. If you do not evaluate JFR events in your environment, disabling them is better.

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2023
@mp911de mp911de added the for: stackoverflow A question that is better suited to stackoverflow.com label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: stackoverflow A question that is better suited to stackoverflow.com
Projects
None yet
Development

No branches or pull requests

2 participants