Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty-handler 4.1.x (SslHandler) flagged as vulnerable dependency #1845

Closed
Bozzzzzo opened this issue Sep 6, 2021 · 5 comments
Closed

netty-handler 4.1.x (SslHandler) flagged as vulnerable dependency #1845

Bozzzzzo opened this issue Sep 6, 2021 · 5 comments
Labels
for: external-project For an external project and not something we can fix status: invalid An issue that we don't feel is valid

Comments

@Bozzzzzo
Copy link

Bozzzzzo commented Sep 6, 2021

Bug Report

Well policy says that for security vulnerabilities we should NOT give away any details.
So I would only say that the enterprise grade code scan engine we are using in our corp.
reports a security "vulnerability" in a third party that you are using...

I tried searching for a corresponding fixed bug report in your project but had no luck.
Reading some of your code around potential vulnerable use ;
I could not determine if vulnerability is effective or not
(though I incline to believe it is not).

I'll be waiting for your contact back.

Environment

at least lettuce-core [5.3.1 to 6.1.x] are using potentially vulnerable code

Possible Solution

No upgraded release available yet.
You may need to work around.

Additional context

MITM

@mp911de
Copy link
Collaborator

mp911de commented Sep 6, 2021

Can you check whether your finding is a duplicate of #1177 or #1264? These come up quite often as false positives. Feel free to provide more details on a 3rd party library in case a version containing the fix is already publicly available.

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Sep 6, 2021
@Bozzzzzo
Copy link
Author

Bozzzzzo commented Sep 6, 2021

No this is neither of those two.
(Interestingly enough the second issue contains a snapshot taken from same code scan engine that I am using)
And no, there is no fixed RELEASE version of the third party lib.
(otherwise I may have tried forcing maven on using that version by using dependencyManagement before pesting you)

@Bozzzzzo
Copy link
Author

Bozzzzzo commented Sep 7, 2021

(I am sending more information in private mail)

@Bozzzzzo
Copy link
Author

Bozzzzzo commented Sep 7, 2021

The problem was an insecure default configuration in netty-handler as discussed in netty/netty#10362

@mp911de mp911de changed the title Potential security vulnerability reported in third party your are using netty-handler 4.1.x (SslHandler) flagged as vulnerable dependency Sep 8, 2021
@mp911de
Copy link
Collaborator

mp911de commented Sep 8, 2021

Thanks for reaching out. Netty's SslHandler doesn't enable certificate checking according to HTTPS semantics by default. Lettuce isn't affected by this default behavior as we configure SSL verification according to the settings in RedisURI which defaults to full SSL certificate verification. In the context of Lettuce, you can disregard such warnings as a false positive.

There's currently no netty 5.0 release available hence we cannot upgrade to a non-affected version. In any case, that wouldn't change anything on the experienced security features in Lettuce, it would only make the dependency scanner happier.

@mp911de mp911de closed this as completed Sep 8, 2021
@mp911de mp911de added status: invalid An issue that we don't feel is valid for: external-project For an external project and not something we can fix and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

2 participants