Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicrometerCommandLatencyRecorder is missing from 6.0.x release #1613

Closed
jnopnop opened this issue Feb 4, 2021 · 2 comments
Closed

MicrometerCommandLatencyRecorder is missing from 6.0.x release #1613

jnopnop opened this issue Feb 4, 2021 · 2 comments
Labels
status: invalid An issue that we don't feel is valid

Comments

@jnopnop
Copy link

jnopnop commented Feb 4, 2021

Hi,

I was about to try out the micrometer integration (see #795). But it appears that both io.lettuce.core.metrics.MicrometerCommandLatencyRecorder and io.lettuce.core.metrics.MicrometerOptions are missing in the 6.0.2.RELEASE.
Those classes are present in main but were not transferred to 6.0.x.
Since the documentation mentions Micrometer integration (see https://lettuce.io/core/snapshot/reference/#command.latency.metrics.micrometer), I guess this is an issue.
Could you please make release with those classes included?

Thank You!

@mp911de
Copy link
Collaborator

mp911de commented Feb 4, 2021

The Micrometer integration is shipped with Lettuce 6.1 (see https://lettuce.io/core/snapshot/reference/#observability.metrics). We build the docs from the unversioned GitHub wiki and that is why some newer features appear in the documentation.

@jnopnop
Copy link
Author

jnopnop commented Feb 4, 2021

Got it. Sorry for misunderstanding. Looking forward for 6.1 release 🙂

@mp911de mp911de added the status: invalid An issue that we don't feel is valid label Feb 5, 2021
@mp911de mp911de closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

2 participants