Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to transform map argument for redis.msetnx({a:123,b:345}) #218

Closed
garkin opened this issue Dec 20, 2015 · 3 comments
Closed

Fails to transform map argument for redis.msetnx({a:123,b:345}) #218

garkin opened this issue Dec 20, 2015 · 3 comments

Comments

@garkin
Copy link

garkin commented Dec 20, 2015

Fails to transform map argument for redis.msetnx({a:123,b:345})
Somehow related to #217

Before this.initPromise()#:
image

After:
image

@luin
Copy link
Collaborator

luin commented Dec 20, 2015

There's no argument transformer for msetnx yet. The built-in ones can be found here: https://github.com/luin/ioredis/blob/master/lib/command.js#L302-L335, and you can define one yourself for msetnx.

However, I think we should have a built-in transformer for msetnx 😆 .

@garkin
Copy link
Author

garkin commented Dec 20, 2015

I think it's pretty inconsistent to have msetnx API differ from mset.
Since it should be just an mset with a blackjack.

@luin
Copy link
Collaborator

luin commented Dec 20, 2015

Yes, you're right. Didn't notice this command when I implemented transformers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants