Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdevent adapter #1144

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Add sdevent adapter #1144

merged 1 commit into from
Dec 21, 2022

Conversation

Oipo
Copy link
Contributor

@Oipo Oipo commented Dec 15, 2022

No description provided.

@michael-grunder
Copy link
Collaborator

Thanks for the PR, I'll go over it this weekend.

bjosv
bjosv reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a small nit..

adapters/libsdevent.h Outdated Show resolved Hide resolved
@Oipo
Copy link
Contributor Author

Oipo commented Dec 21, 2022

Thanks for the review, updated the code.

@michael-grunder michael-grunder merged commit 97fcf0f into redis:master Dec 21, 2022
@michael-grunder
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosv bjosv bjosv left review comments

@michael-grunder michael-grunder michael-grunder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oipo @michael-grunder @bjosv