Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Make SUPPORTED array in config.py more adaptable #523

Open
sadsfae opened this issue Sep 20, 2024 · 1 comment
Open

[RFE] Make SUPPORTED array in config.py more adaptable #523

sadsfae opened this issue Sep 20, 2024 · 1 comment

Comments

@sadsfae
Copy link
Member

sadsfae commented Sep 20, 2024

Currently we have to define supported Dell systems so that the Badfish library in QUADS knows to do special things that Dell is capable of during the M&R QUADS Phase:

https://github.com/redhat-performance/quads/blob/latest/src/quads/config.py#L86

This is referenced here:

https://github.com/redhat-performance/quads/blob/latest/src/quads/helpers/utils.py#L10

and then M&R decides which hosts to action as Dell systems or not here:

https://github.com/redhat-performance/quads/blob/latest/src/quads/tools/move_and_rebuild.py#L189

Solution

Let's pull the SUPPORTED array out of config.py and into it's own /opt/quads/conf/dell_models.py

Why

  • users would have to modify this to add their own Dell models here, requiring them to edit RPM-managed codebase files.
  • if it's kept in its own configuration file we can use %config noreplace in the packaging so what users add isn't overwritten
@sadsfae
Copy link
Member Author

sadsfae commented Sep 20, 2024

Discussing this more with @grafuls the ideal solution is to simply just gate on Dell vendor:

https://github.com/redhat-performance/quads/blob/latest/src/quads/config.py#L86

This way we won't have to keep expanding this model list nor have to worry about having to match if a user uses a different variation or sub-variation, all we care about is if it's a Dell or not. If it doesn't work it means we don't have that model either and we can turn that into an RFE for Badfish to support it.

@sadsfae sadsfae changed the title [RFE] Move SUPPORTED array in config.py to it's own configurable YAML [RFE] Make SUPPORTED array in config.py more adaptable Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

1 participant