Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [RFE] Assignments/per-cloud summaries should only list functional, usable hosts not include broken or retired #389

Closed
sadsfae opened this issue Aug 31, 2021 · 0 comments

Comments

@sadsfae
Copy link
Member

sadsfae commented Aug 31, 2021

  • Rather than file two separate issues with what could mostly be combined into a double-kill filing this as both RFE and BUG. This is mostly a bug report but it does enhance wiki data accuracy so could be considered an RFE also.

Summary

  • Remove broken hosts from systems assignment total
  • Remove retired hosts from systems assignment total
  • Remove retired and broken hosts from resource/default-cloud summary

Fix Counts from Assignments Totals

The dynamically generated assignments page should not count retired hosts (via --ls-retired) in either cloud counts in case of cloud01` or resource pool and also omit broken hosts.

This may be due to Default cloud membership?

https://github.com/redhat-performance/quads/blob/master/quads/tools/create_input_assignments.py#L154

# quads-cli --ls-hosts | wc -l
1085

The correct, usable number should instead be 1071 if we subtract broken systems.

# quads-cli --ls-broken | wc -l
14

1085 - 14 = 1071

  • Wiki currently reports 1217 however, which seems to include both broken systems as well as retired systems.
# quads-cli --ls-retired | wc -l
132

132 + 1085 = 1217

Per Cloud Tallies / Views

Lastly, cloud01 or default resource cloud is listing both retired and broken hosts in its line-item summary count.

In our example, cloud01 only has 27 x real, functional and usable hosts. The wiki does list these hostnames only however both the line-item systems wiki count lists usable + broken + retired.

This is evident from quads-cli which calls the same API endpoint

# quads-cli --cloud-only cloud01 | wc -l
173

However this is the real number:

173 - 14 (minus broken hosts)
159
159 - 132 (minus retired hosts)
27 (actual count)

This BUG/RFE triple-hitter bounty is awarded an ultra-kill modifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant