Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need exclusive file locking. #109

Closed
kambiz-aghaiepour opened this issue Jul 12, 2017 · 1 comment
Closed

Need exclusive file locking. #109

kambiz-aghaiepour opened this issue Jul 12, 2017 · 1 comment

Comments

@kambiz-aghaiepour
Copy link
Contributor

Under very rare circumstances it is possible for the schedule yaml data to be written out partially by one process, and before the process has a chance to completely write out the data in memory, another process will attempt to load the yaml data and take action. Depending on if the partially written yaml data is consistent (but incomplete) this can yield unexpected results.

The fix would be to ensure there is an exclusive lock on the yaml data. This should be done in both the read and write operations.

@sadsfae
Copy link
Member

sadsfae commented Jul 17, 2017

This needs to be implemented solely within the write functions, read() will cause blocking issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants