Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics shouldn't span the entire document #19

Closed
gatesn opened this issue Nov 17, 2017 · 2 comments
Closed

Diagnostics shouldn't span the entire document #19

gatesn opened this issue Nov 17, 2017 · 2 comments
Assignees

Comments

@gatesn
Copy link

gatesn commented Nov 17, 2017

With large files ~10k lines, Monaco/VSCode performance degrades when a diagnostic spans a large number of those lines.

Syntax errors can cause the YAML Language Server to report a diagnostic from the location of the error all the way to EOF. Is it possible to force these errors to be restricted to a single line? Or even character when they cause unrecoverable parser errors?

@JPinkney
Copy link
Contributor

I'm going to look into this and see what we can do

@jiahuijiang
Copy link

Can we cut a release with the fix? :D thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants