Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the error messages great again #65

Open
pwright opened this issue Feb 4, 2021 · 4 comments
Open

Make the error messages great again #65

pwright opened this issue Feb 4, 2021 · 4 comments
Milestone

Comments

@pwright
Copy link

pwright commented Feb 4, 2021

Is your enhancement related to a problem? Please describe.

"Terminal is disabled for cluster-admin users" is buried in the error message, and the prompt 'Please try again' stands out

image

Describe the solution you'd like

Don't ask users to try again if they are doing something that isn't supported

Describe alternatives you've considered

Dont' present the web terminal icon in the console if I'm logged in as cluster admin

Additional context

The context is that i'm tired and didn't notice the exact message, and I kept trying again (was just doing what the console said to do!)

@sleshchenko
Copy link
Contributor

OpenShift 4.7 is going to have the ability for cluster-admins to user terminals. So, this issue is just waits until WTO 1.2 is realeased

@sleshchenko sleshchenko modified the milestones: 1.2, 1.2.0 Feb 10, 2021
@pwright
Copy link
Author

pwright commented Feb 10, 2021

thanks @sleshchenko will there be an option to disable cluster-admin access?

@sleshchenko
Copy link
Contributor

thanks @sleshchenko will there be an option to disable cluster-admin access?

that was not planned and as result not implemented.
What is the reason to disable it for cluster admin?

@pwright
Copy link
Author

pwright commented Feb 15, 2021

Just thought that some folks might want to enable web terminal for developers and not for cluster-admin, but that might just be my imagination ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants