Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we required tkn cli command to start pipeline? #528

Closed
sudhirverma opened this issue Mar 18, 2021 · 3 comments · Fixed by #556
Closed

Do we required tkn cli command to start pipeline? #528

sudhirverma opened this issue Mar 18, 2021 · 3 comments · Fixed by #556
Assignees
Milestone

Comments

@sudhirverma
Copy link
Contributor

As we have two methods to start pipeline from YAML data and tkn cli start command it would be good to use one method to start the pipeline. As VolumeClaimTemplates is not supported in tkn cli start command.

cc: @siamaksade and @evidolob

@sudhirverma sudhirverma added this to the 0.14.0 milestone Mar 24, 2021
@sudhirverma sudhirverma self-assigned this Mar 24, 2021
@lstocchi
Copy link
Contributor

lstocchi commented Apr 6, 2021

@sudhirverma I found this tektoncd/cli#1066. Doesn't the tkn cli start command work with VolumeClaimTemplates or you missed this patch? I still didn't test it, just wanted to know if you have more info on it before to start adding VolumeClaimTemplates support in IJ Tekton.

@sudhirverma
Copy link
Contributor Author

sudhirverma commented Apr 6, 2021

@lstocchi In pipeline start documentation https://github.com/tektoncd/cli/blob/main/docs/cmd/tkn_pipeline_start.md they have not provided the information about VolumeClaimTemplates, If they provide support for VolumeClaimTemplates in tkn start command. Then I will use only tkn command to start the pipeline.

@lstocchi
Copy link
Contributor

lstocchi commented Apr 6, 2021

Ah ok, got it. Either they forgot to update the readme or this thing doesn't work at all (maybe it was deleted in a later PR??). I'll test it as well for IJ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants