Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on 'vscode.env.openExternal' API instead of 3'd party lib #1249

Closed
azatsarynnyy opened this issue Oct 25, 2019 · 1 comment · Fixed by #1254
Closed

Rely on 'vscode.env.openExternal' API instead of 3'd party lib #1249

azatsarynnyy opened this issue Oct 25, 2019 · 1 comment · Fixed by #1254
Assignees
Labels
In Progress kind/enhancement New feature or request
Milestone

Comments

@azatsarynnyy
Copy link
Member

Hello,

I noticed that the open library is used by the extension for opening the URLs externally, in a browser.

Is there a reason why the VS Code's vscode.env.openExternal API isn't used for that? Maybe that API has been added recently?

Would you be interested in such a contribution?
If there's some concern that vscode.env.openExternal API may not work in some cases, then open lib can be used as a fallback option.

@dgolovin
Copy link
Collaborator

@azatsarynnyy thank you for the suggestion, it's been part of API for 9 month. I see no reason using open if vscode.env.openExternal works. Will test it and switch to it if it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment