Signature Help sometimes doesn't work on constructors and qualified method declarations

[zhouxinghong]

Deprecated. . .

[testforstephen]

Your video is broken, i just saw a blank screen there.

[zhouxinghong]

Please download and watch again. . .

[testforstephen]

i couldn't open this video in macOS, but i finally saw your video on a Windows machine.

Your issue is about signatureHelp feature. I reproduced it using eclipse.jdt.ls source code itself.

Move the cursor over the sendStatus method and then trigger the parameter hint (aka. signature help), and it will show some other unrelated method parameters like equals.

[snjeza]

Related issue - eclipse-jdtls/eclipse.jdt.ls#1980
@zhouxinghong Could you reproduce the issue in VS Code 1.3.0?

[snjeza]

@zhouxinghong Could you, please, attach a sample project?

[snjeza]

This issue has been confirmed by the testers above. . . You can consult them for specific reasons. . . @testforstephen

i couldn't open this video in macOS, but i finally saw your video on a Windows machine.

Your issue is about signatureHelp feature. I reproduced it using eclipse.jdt.ls source code itself.

Move the cursor over the sendStatus method and then trigger the parameter hint (aka. signature help), and it will show some other unrelated method parameters like equals.

@zhouxinghong I can't reproduce this issue in VS Code 1.3.0. It has been fixed with eclipse-jdtls/eclipse.jdt.ls#1981

Unable to view method/parameters overloads

Does CA (Ctrl-Space) work properly?

[nimatrueway]

Not an irrelevant parameter hint case; but I have a very simple project with 2 classes that if you try to invoke parameter hint on new AuthenticationService(...) nothing shows up.

sample.zip

[snjeza]

The following is the performance of 1.3.0. . .
Unable to view method/parameters overloads

@zhouxinghong Does CA (Ctrl-Space) work properly here?

Not an irrelevant parameter hint case; but I have a very sample project with 2 classes that if you try to invoke parameter hint on new AuthenticationService(...) nothing shows up.

@nimatrueway I can reproduce the issue. I will try to fix it.

[snjeza]

@zhouxinghong @nimatrueway Could you, please, check https://github.com/snjeza/vscode-test/raw/master/java-1.4.0.vsix ?

[rgrunber]

I just checked upstream Eclipse, and this functionality seems a bit broken there. I suspect we have some workarounds of our own to react to some of the unwanted behaviour. Almost looks like there's confusion between matching methods that satisfy the parameter type, with overloaded methods whose signature should be considered.

Update : eclipse-jdtls/eclipse.jdt.ls#2014 (comment) also mentions some regressions.