Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Revisit instructions about metrics configuration? #68

Open
simonpasquier opened this issue Nov 25, 2022 · 1 comment
Open

Revisit instructions about metrics configuration? #68

simonpasquier opened this issue Nov 25, 2022 · 1 comment

Comments

@simonpasquier
Copy link

The instructions at https://github.com/redhat-cop/resource-locker-operator#metrics are problematic for 2 reasons:

  • Only namespaces of OCP "core" and Red Hat certified components are supposed to be labeled with openshift.io/cluster-monitoring="true" . Anything else should be scraped by the user-defined monitoring stack or a custom deployed Prometheus. The current advice goes against the support conditions, meaning that we could consider the cluster to be unsupported.
  • If a user "forgets" to label the namespace and user-defined monitoring is enabled, the PrometheusOperatorRejectedResources alert will fire because the service monitor uses bearerTokenFile which is forbidden in this case (to avoid users getting access to the service account's token).

cc @jan--f

@simonpasquier
Copy link
Author

The same comment applies to https://github.com/redhat-cop/group-sync-operator btw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant