Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD v1alpha1 depreciated with 1.10 #249

Closed
strangiato opened this issue Oct 11, 2023 · 0 comments · Fixed by #250
Closed

ArgoCD v1alpha1 depreciated with 1.10 #249

strangiato opened this issue Oct 11, 2023 · 0 comments · Fixed by #250

Comments

@strangiato
Copy link
Contributor

OpenShift GitOps 1.10 depreciated the v1alpha1 API and it should be updated to v1beta1.

When applying the current OpenShift GitOps instance you get the following warning:

Warning: ArgoCD v1alpha1 version is deprecated and will be converted to v1beta1 automatically. Moving forward, please use v1beta1 as the ArgoCD API version.
Warning: resource argocds/openshift-gitops is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by oc apply. oc apply should only be used on resources created declaratively by either oc create --save-config or oc apply. The missing annotation will be patched automatically.
argocd.argoproj.io/openshift-gitops configured

The API version in the instance should be updated. Need to validate if anything else needs to change.

Based on this:

https://access.redhat.com/documentation/en-us/red_hat_openshift_gitops/1.10/html-single/release_notes/index#new-features-1-10-0_gitops-release-notes

I think that everything should be fine since we are already using spec.sso.dex instead of spec.dex.

@gnunn1 Do you know of anything else with this API change that we should be aware of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant