From 3f4378a37efb8f4c9d88b0e49428b4e624ae291e Mon Sep 17 00:00:00 2001 From: Sean Sullivan Date: Mon, 13 Mar 2023 12:44:16 -0400 Subject: [PATCH] Update linting (#90) * update * update * update tests and fix ci * update lint * update readme * update requirements * update linting --- changelogs/fragments/.gitkeep | 0 changelogs/fragments/changed_when_lint.yml | 4 ++++ .../tasks/00_gather_custom_requirements.yml | 2 ++ 3 files changed, 6 insertions(+) create mode 100644 changelogs/fragments/.gitkeep create mode 100644 changelogs/fragments/changed_when_lint.yml diff --git a/changelogs/fragments/.gitkeep b/changelogs/fragments/.gitkeep new file mode 100644 index 0000000..e69de29 diff --git a/changelogs/fragments/changed_when_lint.yml b/changelogs/fragments/changed_when_lint.yml new file mode 100644 index 0000000..682bc95 --- /dev/null +++ b/changelogs/fragments/changed_when_lint.yml @@ -0,0 +1,4 @@ +--- +minor_changes: + - Added changed_when false to built in commands that gather information. +... diff --git a/roles/virtualenv_migrate/tasks/00_gather_custom_requirements.yml b/roles/virtualenv_migrate/tasks/00_gather_custom_requirements.yml index a80a7bf..466c424 100644 --- a/roles/virtualenv_migrate/tasks/00_gather_custom_requirements.yml +++ b/roles/virtualenv_migrate/tasks/00_gather_custom_requirements.yml @@ -20,12 +20,14 @@ - not venv_migrate_show_diff_with_default - __venv_migrate_virtualenvs | length > 1 register: __venv_migrate_freeze_results + changed_when: false # only gathering information - name: Gather pip freeze output from all venvs including the default venv ansible.builtin.command: "{{ item }}/bin/pip freeze" loop: "{{ __venv_migrate_virtualenvs }}" when: venv_migrate_show_diff_with_default | bool register: __venv_migrate_freeze_results_default + changed_when: false # only gathering information - name: Gather results from pip_freeze based on conditions ansible.builtin.set_fact: