fixed job template issue with empty survey spec #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecchong
requested review from
silvinux,
ivarmu and
adonisgarciac
as code owners
|
Duplicated. This is solved at https://github.com/redhat-cop/aap_configuration_extended/pull/51/files#diff-a93146062a168a4cff18194dc3d2a13125cd10f1849e8ad7c869655d8b2417edL208-R208. Anyway, not sure what approach is better... Open to suggestions here. @djdanielsson |
|
because it is a duplicate I will just close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
filetree_create failed when job template has no survey spec
It seems the query for related survey_spec returns a list with a single empty dictionary, i.e.
[{}], which causes the following condition check ofsurvey_spec_contents | length > 0to pass even there is no survey spec.This PR added a filter
difference([{}])to remove the empty dictionary from the returned list.How should this be tested?
Run filetree_create role against job template with no survey spec defined
Is there a relevant Issue open for this?
None
Other Relevant info, PRs, etc