From e17d504b09ce4e13a6897fa4b519e0262d076cff Mon Sep 17 00:00:00 2001 From: Russ Panula Date: Tue, 15 Aug 2017 17:52:58 -0500 Subject: [PATCH 1/3] fix require.cache.hasOwnProperty call for Node 8 --- packages/react-server-cli/src/serverSideHotModuleReload.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-server-cli/src/serverSideHotModuleReload.js b/packages/react-server-cli/src/serverSideHotModuleReload.js index edf83efaf..56cedfb77 100644 --- a/packages/react-server-cli/src/serverSideHotModuleReload.js +++ b/packages/react-server-cli/src/serverSideHotModuleReload.js @@ -27,7 +27,7 @@ export default function serverSideHotModuleReload (webpackStats) { // For now, loop through all of the project code to remove require caches so that we ensure the server is most up // to date. Object.keys(require.cache).map((filename) => { - if (/node_modules/.test(filename) === false && require.cache.hasOwnProperty(filename)) { + if (/node_modules/.test(filename) === false && Object.prototype.hasOwnProperty.call(require.cache, filename)) { logger.info(`Reloading file: ${filename}`); delete require.cache[filename]; } From 7497afc7be42d0d0b92b2307df5bcc2eacedac96 Mon Sep 17 00:00:00 2001 From: Russ Panula Date: Tue, 15 Aug 2017 18:22:40 -0500 Subject: [PATCH 2/3] npm nuke script needs "rm -rf node_modules" in case node_modules doesn't exist --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index f8796e594..9dcffbd73 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "bootstrap-no-i": "lerna bootstrap", "test": "lerna run test", "clean": "rimraf lerna-debug.log && lerna run clean", - "nuke": "npm run clean && lerna clean --yes && rm -r node_modules", + "nuke": "npm run clean && lerna clean --yes && rm -rf node_modules", "changelog": "lerna-changelog", "debug": "cat lerna-debug.log && for d in packages/*/npm-debug.log*; do echo $d; cat $d; done", "postinstall": "npm run bootstrap-no-i", From 2f4fd759c0cab636ac1f983aa1e8d73609187e7d Mon Sep 17 00:00:00 2001 From: Russ Panula Date: Tue, 15 Aug 2017 18:26:03 -0500 Subject: [PATCH 3/3] add notes about dependencies to MAINTAINING.md --- MAINTAINING.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINING.md b/MAINTAINING.md index 3f6f8a2ac..291d33f18 100644 --- a/MAINTAINING.md +++ b/MAINTAINING.md @@ -1,3 +1,9 @@ +### Dependencies + +- `npm install -g rimraf` +- `npm install -g lerna` +- `npm install -g del-cli` + ### Deployment Checklist - `git checkout master && git pull upstream master`