Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-server-redux breaks production compile #912

Closed
mocheng opened this issue Mar 27, 2017 · 1 comment
Closed

react-server-redux breaks production compile #912

mocheng opened this issue Mar 27, 2017 · 1 comment
Labels
bug An issue with the system

Comments

@mocheng
Copy link
Contributor

mocheng commented Mar 27, 2017

With importing of react-server-redux, command NODE_ENV=production react-server compile" fails.

The importing of ReduxAdapter is simple as below.

import {ReduxAdapter} from 'react-server-redux';

The command NODE_ENV=production react-server compile" fails with below message.

There were errors in the JavaScript compilation.
Home.ab7d7e279a3596bd49b0.bundle.js from UglifyJs
SyntaxError: Unexpected token: name (ReduxAdapter) [./~/react-server-redux/ReduxAdapter.js:1,0]
2017-03-27T06:09:24.996Z - error: [react-server-cli.src.commands.compile] message=There were errors in the JavaScript compilation., stack=Error: There were errors in the JavaScript compilation.
at handleCompilationErrors (/Users/morgan.cheng/github/react-server-demo/node_modules/react-server-cli/target/handleCompilationErrors.js:25:10)

The UglifyJS reports SyntaxError: Unexpected token: name (ReduxAdapter), even though npm start works fine.

I have a minimalist app to repo this problem: https://github.com/mocheng/react-server-demo

@mocheng
Copy link
Contributor Author

mocheng commented Mar 27, 2017

This issue might related to the fact that react-server-redux is not transpiled in publishing.

@gigabo gigabo added the bug An issue with the system label Apr 7, 2017
@sresant sresant closed this as completed Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

No branches or pull requests

3 participants