Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Path Issues in routes_client.js #832

Closed
drewpc opened this issue Jan 14, 2017 · 1 comment · Fixed by #833
Closed

File Path Issues in routes_client.js #832

drewpc opened this issue Jan 14, 2017 · 1 comment · Fixed by #833
Assignees
@drewpc
Labels
bug An issue with the system

Comments

@drewpc
Copy link
Collaborator

drewpc commented Jan 14, 2017

When creating the client bundle with Webpack, the __clientTemp/routes_client.js file fails to handle Windows file paths such as C:\my\path\to\module.js and any path with a single apostrophe in them. This prevents react-server from running on Windows and some Unix environments.
@drewpc drewpc added the bug An issue with the system label Jan 14, 2017
@drewpc drewpc changed the title Fix File Path Issues in routes_client.js File Path Issues in routes_client.js Jan 14, 2017
@drewpc drewpc self-assigned this Jan 14, 2017
@drewpc drewpc mentioned this issue Jan 14, 2017
Merged
@drewpc
Copy link
Collaborator Author

drewpc commented Jan 17, 2017

Dup of #534 but this also identifies other issues with paths on UNIX such as ' or " in them.

@drewpc drewpc mentioned this issue Jan 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewpc drewpc

Labels
bug An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix file path issues SoprisApps/react-server
1 participant
@drewpc