Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename __clientTemp and separate client and server build #799

Open
jhnns opened this issue Jan 4, 2017 · 2 comments
Open

Rename __clientTemp and separate client and server build #799

jhnns opened this issue Jan 4, 2017 · 2 comments

Comments

@jhnns
Copy link
Contributor

jhnns commented Jan 4, 2017

Following up #794


Currently, all webpack output is located under __clientTemp. To me, this is confusing because the folder does not only contain client stuff, it's also not temporary. It's the actual build artifact that people will deploy.

I would recommend to rename __clientTemp to build or dist (we can bikeshed about that 😉) which contains two folders, client and server.

@doug-wade
Copy link
Collaborator

I dig it. If I understand #791 correctly, __clientTemp is a particularly bad name, since it will also be the server temp directory. I'm leaning towards build, personally, though either strikes me as an improvement.

@breezewish
Copy link

Could you also make it configurable? Currently we have deployment phase and dev phase. Currently they use the same directory and affect each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants