Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-absolute URLs in stylesheets cause client-side stylesheet resolution machinery to replace stylesheets #116

Closed
roblg opened this issue Apr 27, 2016 · 2 comments
Closed

non-absolute URLs in stylesheets cause client-side stylesheet resolution machinery to replace stylesheets #116

roblg opened this issue Apr 27, 2016 · 2 comments
Labels
bug An issue with the system

Comments

@roblg
Copy link
Member

roblg commented Apr 27, 2016

I noticed this while working on #115

It seems like if the server returns a relative URL for a stylesheet, the client-side code in ClientCssHelper sees an absolute URL in the document, and when it compares that to the relative URL returned by getHeadStylesheets client-side, it thinks they're different and replaces them.

I didn't have time to investigate deeply, but I think this is what's happening. (I don't think it's something that #115 introduced)
@roblg roblg mentioned this issue Apr 27, 2016
Merged
@gigabo gigabo added the bug An issue with the system label Apr 29, 2016
@gigabo
Copy link
Contributor

gigabo commented Nov 30, 2016

I think this was fixed by #501. @roblg does that look right?

@roblg
Copy link
Member Author

roblg commented Nov 30, 2016

Seems plausible, yep.

@gigabo gigabo closed this as completed Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue with the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gigabo @roblg