Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: System Message Support #1639

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

andrewbrazzatti
Copy link
Contributor

Basic support for displaying a system message in the app to allow administrators to notify of upcoming maintenance.

Message is enabled by setting the language code "system-message-enabled" to the value "true". The title of the system message can then be set via "system-message-title" and the description can be set via "system-message-description".

To avoid persistent nagging of users, the message can be dismissed and won't show again on the same browser for a period of 8 hours.

Future versions may move enabling to brand specific configuration and support multiple system message.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (765d179) 70.05% compared to head (8aefdc9) 70.05%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1639   +/-   ##
========================================
  Coverage    70.05%   70.05%           
========================================
  Files          111      111           
  Lines         1870     1870           
  Branches       218      218           
========================================
  Hits          1310     1310           
  Misses         560      560           
Flag Coverage Δ
frontend-core-lib 52.41% <ø> (ø)
frontend-dashboard 88.07% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewbrazzatti andrewbrazzatti merged commit 00a9b86 into develop Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant