Dropping the .altinstr_replacement section from the toolchain #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me |
|
This needs a Changelog entry for ofrak-patch-maker. Probably can be considered a bugfix. |
|
I'm curious what triggered discovery of this issue. Has it always been around, or is this something new? Did a change create it? |
|
We observed this section when working on code for AARCH64 Linux 4 |
|
Pending further feedback, can we merge this in? |
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Feb 18, 2024
…loonsecurity#414) * Dropping the .altinstr_replacement section from the toolchain * Updated CHANGELOG
whyitfor
added a commit
that referenced
this pull request
Feb 22, 2024
* Use python3.8 in docker images * Require pytest<8.0 This is needed becase of pytest-dev/pytest#11890 TvoroG/pytest-lazy-fixture#65 * Update changelog * Revert "Update changelog" This reverts commit 500ee9b. Making changes before having coffee :( * Update to latest angr==9.2.89, which also necessitates Python >= 3.8 and capstone==5.0.0.post1 * Apply Edward's attempted fix to angr test failure * Add a note on recommending Python 3.8 * Add a note on recommending Python 3.8 * Document the requirement of Python 3.8+ * Switch to angr 9.2.77 * `ofrak_core` also needs `pytest<8.0` * ignore DataWord in test due to angr bug * add another now missing block * black linting * Attempt to fix a capstone error * Dropping the .altinstr_replacement section from the toolchain (#414) * Dropping the .altinstr_replacement section from the toolchain * Updated CHANGELOG * Set the fallback font to monospace (#422) * Set the fallback font to monospace * Update CHANGELOG * Display strings with numbers primarily as strings (#423) * Display strings with numbers primarily as strings * Update CHANGELOG * Add typing support to ofrak_ghidra package (#421) * Add typing to ofrak_ghidra package * Add changelog --------- Co-authored-by: Paul Noalhyt <[email protected]> * Increase time limit on `test_comment_content` * Fix a spurious "no current event loop" test error * Explain 3.7 vs 3.8 better in the docs * Cite specific versions of angr in comment * Update docs/environment-setup.md * Update docs/getting-started.md --------- Co-authored-by: Edward Larson <[email protected]> Co-authored-by: rbs-alexr <[email protected]> Co-authored-by: Jacob Strieb <[email protected]> Co-authored-by: Paul Noalhyt <[email protected]> Co-authored-by: Paul Noalhyt <[email protected]> Co-authored-by: Wyatt <[email protected]>
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
May 30, 2024
…loonsecurity#414) * Dropping the .altinstr_replacement section from the toolchain * Updated CHANGELOG
ANogin
added a commit
to ANogin/ofrak
that referenced
this pull request
May 30, 2024
* Use python3.8 in docker images * Require pytest<8.0 This is needed becase of pytest-dev/pytest#11890 TvoroG/pytest-lazy-fixture#65 * Update changelog * Revert "Update changelog" This reverts commit 500ee9b. Making changes before having coffee :( * Update to latest angr==9.2.89, which also necessitates Python >= 3.8 and capstone==5.0.0.post1 * Apply Edward's attempted fix to angr test failure * Add a note on recommending Python 3.8 * Add a note on recommending Python 3.8 * Document the requirement of Python 3.8+ * Switch to angr 9.2.77 * `ofrak_core` also needs `pytest<8.0` * ignore DataWord in test due to angr bug * add another now missing block * black linting * Attempt to fix a capstone error * Dropping the .altinstr_replacement section from the toolchain (redballoonsecurity#414) * Dropping the .altinstr_replacement section from the toolchain * Updated CHANGELOG * Set the fallback font to monospace (redballoonsecurity#422) * Set the fallback font to monospace * Update CHANGELOG * Display strings with numbers primarily as strings (redballoonsecurity#423) * Display strings with numbers primarily as strings * Update CHANGELOG * Add typing support to ofrak_ghidra package (redballoonsecurity#421) * Add typing to ofrak_ghidra package * Add changelog --------- Co-authored-by: Paul Noalhyt <[email protected]> * Increase time limit on `test_comment_content` * Fix a spurious "no current event loop" test error * Explain 3.7 vs 3.8 better in the docs * Cite specific versions of angr in comment * Update docs/environment-setup.md * Update docs/getting-started.md --------- Co-authored-by: Edward Larson <[email protected]> Co-authored-by: rbs-alexr <[email protected]> Co-authored-by: Jacob Strieb <[email protected]> Co-authored-by: Paul Noalhyt <[email protected]> Co-authored-by: Paul Noalhyt <[email protected]> Co-authored-by: Wyatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
We also want to drop the .altinstr_replacement section when we are performing patches
Link to Related Issue(s)
Please describe the changes in your request.
This PR adds .altinstr_replacement to the toolchain's linker section droplist
Anyone you think should look at this, specifically?
@rbs-afflitto also ran into this issue