-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to python3.11 and support for ARM #552
Closed
Jepson2k
wants to merge
19
commits into
redballoonsecurity:master
from
Jepson2k:jepson2k-faster-docker-builds
Closed
Upgrade to python3.11 and support for ARM #552
Jepson2k
wants to merge
19
commits into
redballoonsecurity:master
from
Jepson2k:jepson2k-faster-docker-builds
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith static analysis engines like mypy. This appears to be the lowest effort, semi-future proof approach to keep mypy working. The downside is that non-python files are no longer auto-refreshed when edited.
…ad section and building as well as expecting a license files to be included
…ifier is needed to ensure proper compatability with current setup
… now this will work
…le multiarch support
…, we'd have 100% test coverage on arm. Oh well, maybe a job for a different pr...
This was
linked to
issues
Jan 6, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Added ARM/multi-arch variants of toolchains and upgrade dependencies to support python3.11.
Link to Related Issue(s)
Resolves #547 #548 #549 #546 #543 #542
Please describe the changes in your request.
Initially started as an upgrade to python3.11 to decrease build time on ARM. Quickly found out that there was no way to test that I didn't break anything on ARM because most of the tests failed on ARM anyways, as such I added support for ARM. You should find that it has almost 100% passing test coverage, except for test relating to the BCC toolchain. Might explore in another issue/pr using crosstool-ng to build this for ARM. Added Makefile commands to simplify running all the different configurations.
Anyone you think should look at this, specifically?
@whyitfor @jstrieb