Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows guide broken image in 3.2 #31

Open
ncbaratta opened this issue Jun 13, 2019 · 4 comments
Open

Windows guide broken image in 3.2 #31

ncbaratta opened this issue Jun 13, 2019 · 4 comments
Assignees

Comments

@ncbaratta
Copy link
Contributor

ncbaratta commented Jun 13, 2019

QE by @sparkoo

https://red-hat-openjdk.github.io/docs/windows/index.html#setup-_JDKMissionControl_procedure_windows

@ncbaratta
Copy link
Contributor Author

@robin-owen do you have any ideas on this one. When you see the doc here: https://github.com/red-hat-openjdk/docs/blob/master/modules/proc-windows-setup-jdkmissioncontrol.adoc the image shows, but when you view the built guide it does not. Could it be the build script?

@kowen-rh
Copy link
Contributor

Yes, this would be related to the build script not appropriately copying the images/ directory to docs/images, I believe. This is difficult for me to test locally, but I'm pretty sure we just need to add cp -r images/ docs/images/ to the build.sh script in order for GitHub Pages to pick it up.

@ncbaratta
Copy link
Contributor Author

If you find some time can you give that a whirl? Or we can just leave it be and when we build on the portal we can troubleshoot then.

@kowen-rh
Copy link
Contributor

If you find some time can you give that a whirl?

Yes, absolutely! Apologies for the late response. Taking some time to look into it now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants