CombineIfRector creates fatal error when PHP closing tag at end of if

[kkmuffme]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/6b4b9466-d3fe-449a-a265-5da3f7db4544

<?php

final class DemoFile
{
    public function run(int $param, int $param_two)
    {
        if ($param > 0) {
            if ($param_two > 0) { ?>
                hello
            <?php }
        }
    }
}

Responsible rules

• CombineIfRector

Expected Behavior

rectorphp/rector-src#5565

[samsonasik]

That's the drawback of mix php+html. You can skip the rules for mixed php+html.

Thank you for understanding.

[kkmuffme]

Kind of defeats the purpose of rector, since this is a common pattern in legacy code - which is the purpose of rector, isn't it? On a modern code base I don't need any of those rules in the first place, since these issues don't exist there.

[samsonasik]

Rector is rely on nikic/php-parser, the support should be included there.