From 7850a0d1f64a47b96ac36b3b2464cb47d2d381ca Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Wed, 30 Oct 2019 10:55:04 +0100
Subject: [PATCH] [cs] remove NoClassInstantiationSniff

---
 ecs.yaml | 31 +++----------------------------
 1 file changed, 3 insertions(+), 28 deletions(-)

diff --git a/ecs.yaml b/ecs.yaml
index 143c2e1a3ea1..6fcdbf0271b9 100644
--- a/ecs.yaml
+++ b/ecs.yaml
@@ -24,30 +24,6 @@ services:
                 - 'getNodeTypes'
                 - 'refactor'
 
-    Symplify\CodingStandard\Sniffs\DependencyInjection\NoClassInstantiationSniff:
-        extra_allowed_classes:
-            - 'PHPStan\Type\*'
-            - '*Type'
-            - 'PHPStan\Analyser\Scope'
-            - 'PhpParser\NodeVisitor\NameResolver'
-            - 'PhpParser\Node\*'
-            - '*Data'
-            - '*Recipe'
-            - '*ValueObject'
-            - 'PhpParser\Comment'
-            - 'PhpParser\Lexer'
-            - 'PhpParser\Comment\Doc'
-            - 'PhpParser\NodeTraverser'
-            - 'Rector\Reporting\FileDiff'
-            - 'Rector\RectorDefinition\*'
-            - 'Rector\Application\Error'
-            - 'Rector\DependencyInjection\Loader\*'
-            - 'Symplify\PackageBuilder\*'
-            - 'Symfony\Component\Console\Input\*Input'
-            - 'PHPStan\Analyser\NameScope'
-            - 'PHPStan\Rules\RuleErrors\RuleError*'
-            - '*\XdebugHandler'
-
     Symplify\CodingStandard\Fixer\Naming\PropertyNameMatchingTypeFixer:
         extra_skipped_classes:
             - 'PhpParser\PrettyPrinter\Standard'
@@ -71,6 +47,9 @@ parameters:
         - 'src/Rector/AbstractRector.php'
 
     skip:
+        # rather useless
+        Symplify\CodingStandard\Sniffs\DependencyInjection\NoClassInstantiationSniff: ~
+
         PHP_CodeSniffer\Standards\PSR2\Sniffs\Methods\MethodDeclarationSniff.Underscore: ~
         Symplify\CodingStandard\Sniffs\Architecture\DuplicatedClassShortNameSniff: ~
         # skip temporary due to missing "import" feature in PhpStorm
@@ -184,10 +163,6 @@ parameters:
             - 'packages/DeadCode/src/Rector/ClassMethod/RemoveOverriddenValuesRector.php'
             - 'packages/PhpSpecToPHPUnit/src/Rector/MethodCall/PhpSpecPromisesToPHPUnitAssertRector.php'
 
-        Symplify\CodingStandard\Sniffs\DependencyInjection\NoClassInstantiationSniff:
-            # 3rd party api
-            - 'src/PhpParser/Node/Value/ValueResolver.php'
-
         PhpCsFixer\Fixer\PhpUnit\PhpUnitStrictFixer:
             - 'packages/BetterPhpDocParser/tests/PhpDocInfo/PhpDocInfo/PhpDocInfoTest.php'
             # intentional "assertEquals()"