-
-
Notifications
You must be signed in to change notification settings - Fork 699
/
Copy pathPrivatizeLocalGetterToPropertyRector.php
127 lines (121 loc) · 3.41 KB
/
PrivatizeLocalGetterToPropertyRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
<?php
declare (strict_types=1);
namespace Rector\Privatization\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Return_;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector\PrivatizeLocalGetterToPropertyRectorTest
*/
final class PrivatizeLocalGetterToPropertyRector extends AbstractRector
{
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Privatize getter of local property to property', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
private $some;
public function run()
{
return $this->getSome() + 5;
}
private function getSome()
{
return $this->some;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
private $some;
public function run()
{
return $this->some + 5;
}
private function getSome()
{
return $this->some;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node) : ?Node
{
$class = $node;
$hasChanged = \false;
$isFinal = $class->isFinal();
$this->traverseNodesWithCallable($node, function (Node $node) use($class, &$hasChanged, $isFinal) : ?PropertyFetch {
if (!$node instanceof MethodCall) {
return null;
}
if ($node->isFirstClassCallable()) {
return null;
}
if (!$node->var instanceof Variable) {
return null;
}
if (!$this->nodeNameResolver->isName($node->var, 'this')) {
return null;
}
$methodName = $this->getName($node->name);
if ($methodName === null) {
return null;
}
$classMethod = $class->getMethod($methodName);
if (!$classMethod instanceof ClassMethod) {
return null;
}
if (!$classMethod->isPrivate() && !$isFinal) {
return null;
}
$propertyFetch = $this->matchLocalPropertyFetchInGetterMethod($classMethod);
if (!$propertyFetch instanceof PropertyFetch) {
return null;
}
$hasChanged = \true;
return $propertyFetch;
});
if ($hasChanged) {
return $node;
}
return null;
}
private function matchLocalPropertyFetchInGetterMethod(ClassMethod $classMethod) : ?PropertyFetch
{
if ($classMethod->params !== []) {
return null;
}
$stmts = (array) $classMethod->stmts;
if (\count($stmts) !== 1) {
return null;
}
$onlyStmt = $stmts[0] ?? null;
if (!$onlyStmt instanceof Return_) {
return null;
}
$returnedExpr = $onlyStmt->expr;
if (!$returnedExpr instanceof PropertyFetch) {
return null;
}
return $returnedExpr;
}
}