-
-
Notifications
You must be signed in to change notification settings - Fork 688
/
AddOverrideAttributeToOverriddenMethodsRector.php
225 lines (221 loc) · 7.28 KB
/
AddOverrideAttributeToOverriddenMethodsRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
<?php
declare (strict_types=1);
namespace Rector\Php83\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Attribute;
use PhpParser\Node\AttributeGroup;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Throw_;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassLike;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Expression;
use PhpParser\Node\Stmt\Return_;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\ReflectionProvider;
use Rector\NodeAnalyzer\ClassAnalyzer;
use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
use Rector\PhpParser\AstResolver;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\MethodName;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see https://wiki.php.net/rfc/marking_overriden_methods
*
* @see \Rector\Tests\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector\AddOverrideAttributeToOverriddenMethodsRectorTest
*/
final class AddOverrideAttributeToOverriddenMethodsRector extends AbstractRector implements MinPhpVersionInterface
{
/**
* @readonly
*/
private ReflectionProvider $reflectionProvider;
/**
* @readonly
*/
private ClassAnalyzer $classAnalyzer;
/**
* @readonly
*/
private PhpAttributeAnalyzer $phpAttributeAnalyzer;
/**
* @readonly
*/
private AstResolver $astResolver;
/**
* @readonly
*/
private ValueResolver $valueResolver;
/**
* @var string
*/
private const OVERRIDE_CLASS = 'Override';
private bool $hasChanged = \false;
public function __construct(ReflectionProvider $reflectionProvider, ClassAnalyzer $classAnalyzer, PhpAttributeAnalyzer $phpAttributeAnalyzer, AstResolver $astResolver, ValueResolver $valueResolver)
{
$this->reflectionProvider = $reflectionProvider;
$this->classAnalyzer = $classAnalyzer;
$this->phpAttributeAnalyzer = $phpAttributeAnalyzer;
$this->astResolver = $astResolver;
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Add override attribute to overridden methods', [new CodeSample(<<<'CODE_SAMPLE'
class ParentClass
{
public function foo()
{
echo 'default';
}
}
final class ChildClass extends ParentClass
{
public function foo()
{
echo 'override default';
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class ParentClass
{
public function foo()
{
echo 'default';
}
}
final class ChildClass extends ParentClass
{
#[\Override]
public function foo()
{
echo 'override default';
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node) : ?Node
{
$this->hasChanged = \false;
if ($this->classAnalyzer->isAnonymousClass($node)) {
return null;
}
$className = (string) $this->getName($node);
if (!$this->reflectionProvider->hasClass($className)) {
return null;
}
$classReflection = $this->reflectionProvider->getClass($className);
$parentClassReflections = $classReflection->getParents();
if ($parentClassReflections === []) {
return null;
}
foreach ($node->getMethods() as $classMethod) {
$this->processAddOverrideAttribute($classMethod, $parentClassReflections);
}
if (!$this->hasChanged) {
return null;
}
return $node;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::OVERRIDE_ATTRIBUTE;
}
/**
* @param ClassReflection[] $parentClassReflections
*/
private function processAddOverrideAttribute(ClassMethod $classMethod, array $parentClassReflections) : void
{
if ($this->shouldSkipClassMethod($classMethod)) {
return;
}
/** @var string $classMethodName */
$classMethodName = $this->getName($classMethod->name);
// Private methods should be ignored
$shouldAddOverride = \false;
foreach ($parentClassReflections as $parentClassReflection) {
if (!$parentClassReflection->hasNativeMethod($classMethod->name->toString())) {
continue;
}
// ignore if it is a private method on the parent
if (!$parentClassReflection->hasNativeMethod($classMethodName)) {
continue;
}
$parentMethod = $parentClassReflection->getNativeMethod($classMethodName);
if ($parentMethod->isPrivate()) {
break;
}
if ($this->shouldSkipParentClassMethod($parentClassReflection, $classMethod)) {
continue;
}
$shouldAddOverride = \true;
break;
}
if ($shouldAddOverride) {
$classMethod->attrGroups[] = new AttributeGroup([new Attribute(new FullyQualified(self::OVERRIDE_CLASS))]);
$this->hasChanged = \true;
}
}
private function shouldSkipClassMethod(ClassMethod $classMethod) : bool
{
if ($this->isName($classMethod->name, MethodName::CONSTRUCT)) {
return \true;
}
if ($classMethod->isPrivate()) {
return \true;
}
// ignore if it already uses the attribute
return $this->phpAttributeAnalyzer->hasPhpAttribute($classMethod, self::OVERRIDE_CLASS);
}
private function shouldSkipParentClassMethod(ClassReflection $parentClassReflection, ClassMethod $classMethod) : bool
{
// parse parent method, if it has some contents or not
$parentClass = $this->astResolver->resolveClassFromClassReflection($parentClassReflection);
if (!$parentClass instanceof ClassLike) {
return \true;
}
$parentClassMethod = $parentClass->getMethod($classMethod->name->toString());
if (!$parentClassMethod instanceof ClassMethod) {
return \true;
}
// just override abstract method also skipped on purpose
// only grand child of abstract method that parent has content will have
if ($parentClassMethod->isAbstract()) {
return \true;
}
// has any stmts?
if ($parentClassMethod->stmts === null || $parentClassMethod->stmts === []) {
return \true;
}
if (\count($parentClassMethod->stmts) === 1) {
/** @var Stmt $soleStmt */
$soleStmt = $parentClassMethod->stmts[0];
// most likely, return null; is interface to be designed to override
if ($soleStmt instanceof Return_ && $soleStmt->expr instanceof Expr && $this->valueResolver->isNull($soleStmt->expr)) {
return \true;
}
if ($soleStmt instanceof Expression && $soleStmt->expr instanceof Throw_) {
return \true;
}
}
return \false;
}
}