-
-
Notifications
You must be signed in to change notification settings - Fork 699
/
Copy pathJsonThrowOnErrorRector.php
153 lines (151 loc) · 4.9 KB
/
JsonThrowOnErrorRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
<?php
declare (strict_types=1);
namespace Rector\Php73\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PhpParser\Node\Scalar\Int_;
use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
use Rector\PhpParser\Node\BetterNodeFinder;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Php73\Rector\FuncCall\JsonThrowOnErrorRector\JsonThrowOnErrorRectorTest
*/
final class JsonThrowOnErrorRector extends AbstractRector implements MinPhpVersionInterface
{
/**
* @readonly
*/
private ValueResolver $valueResolver;
/**
* @readonly
*/
private BetterNodeFinder $betterNodeFinder;
private bool $hasChanged = \false;
public function __construct(ValueResolver $valueResolver, BetterNodeFinder $betterNodeFinder)
{
$this->valueResolver = $valueResolver;
$this->betterNodeFinder = $betterNodeFinder;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Adds JSON_THROW_ON_ERROR to json_encode() and json_decode() to throw JsonException on error', [new CodeSample(<<<'CODE_SAMPLE'
json_encode($content);
json_decode($json);
CODE_SAMPLE
, <<<'CODE_SAMPLE'
json_encode($content, JSON_THROW_ON_ERROR);
json_decode($json, null, 512, JSON_THROW_ON_ERROR);
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [StmtsAwareInterface::class];
}
/**
* @param StmtsAwareInterface $node
*/
public function refactor(Node $node) : ?Node
{
// if found, skip it :)
$hasJsonErrorFuncCall = (bool) $this->betterNodeFinder->findFirst($node, fn(Node $node): bool => $this->isNames($node, ['json_last_error', 'json_last_error_msg']));
if ($hasJsonErrorFuncCall) {
return null;
}
$this->hasChanged = \false;
$this->traverseNodesWithCallable($node, function (Node $currentNode) : ?FuncCall {
if (!$currentNode instanceof FuncCall) {
return null;
}
if ($this->shouldSkipFuncCall($currentNode)) {
return null;
}
if ($this->isName($currentNode, 'json_encode')) {
return $this->processJsonEncode($currentNode);
}
if ($this->isName($currentNode, 'json_decode')) {
return $this->processJsonDecode($currentNode);
}
return null;
});
if ($this->hasChanged) {
return $node;
}
return null;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::JSON_EXCEPTION;
}
private function shouldSkipFuncCall(FuncCall $funcCall) : bool
{
if ($funcCall->isFirstClassCallable()) {
return \true;
}
if ($funcCall->args === []) {
return \true;
}
foreach ($funcCall->args as $arg) {
if (!$arg instanceof Arg) {
continue;
}
if ($arg->name instanceof Identifier) {
return \true;
}
}
return $this->isFirstValueStringOrArray($funcCall);
}
private function processJsonEncode(FuncCall $funcCall) : ?FuncCall
{
if (isset($funcCall->args[1])) {
return null;
}
$this->hasChanged = \true;
$funcCall->args[1] = new Arg($this->createConstFetch('JSON_THROW_ON_ERROR'));
return $funcCall;
}
private function processJsonDecode(FuncCall $funcCall) : ?FuncCall
{
if (isset($funcCall->args[3])) {
return null;
}
// set default to inter-args
if (!isset($funcCall->args[1])) {
$funcCall->args[1] = new Arg($this->nodeFactory->createNull());
}
if (!isset($funcCall->args[2])) {
$funcCall->args[2] = new Arg(new Int_(512));
}
$this->hasChanged = \true;
$funcCall->args[3] = new Arg($this->createConstFetch('JSON_THROW_ON_ERROR'));
return $funcCall;
}
private function createConstFetch(string $name) : ConstFetch
{
return new ConstFetch(new Name($name));
}
private function isFirstValueStringOrArray(FuncCall $funcCall) : bool
{
if (!isset($funcCall->getArgs()[0])) {
return \false;
}
$firstArg = $funcCall->getArgs()[0];
$value = $this->valueResolver->getValue($firstArg->value);
if (\is_string($value)) {
return \true;
}
return \is_array($value);
}
}