-
-
Notifications
You must be signed in to change notification settings - Fork 688
/
RemoveExtraParametersRector.php
146 lines (144 loc) · 5.08 KB
/
RemoveExtraParametersRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
<?php
declare (strict_types=1);
namespace Rector\Php71\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Name;
use PHPStan\Reflection\FunctionReflection;
use PHPStan\Reflection\MethodReflection;
use PHPStan\Reflection\Php\PhpMethodReflection;
use PHPStan\Reflection\Type\UnionTypeMethodReflection;
use Rector\Enum\ObjectReference;
use Rector\NodeAnalyzer\VariadicAnalyzer;
use Rector\Rector\AbstractRector;
use Rector\Reflection\ReflectionResolver;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Php71\Rector\FuncCall\RemoveExtraParametersRector\RemoveExtraParametersRectorTest
*/
final class RemoveExtraParametersRector extends AbstractRector implements MinPhpVersionInterface
{
/**
* @readonly
*/
private VariadicAnalyzer $variadicAnalyzer;
/**
* @readonly
*/
private ReflectionResolver $reflectionResolver;
public function __construct(VariadicAnalyzer $variadicAnalyzer, ReflectionResolver $reflectionResolver)
{
$this->variadicAnalyzer = $variadicAnalyzer;
$this->reflectionResolver = $reflectionResolver;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::NO_EXTRA_PARAMETERS;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove extra parameters', [new CodeSample('strlen("asdf", 1);', 'strlen("asdf");')]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [FuncCall::class, MethodCall::class, StaticCall::class];
}
/**
* @param FuncCall|MethodCall|StaticCall $node
*/
public function refactor(Node $node) : ?Node
{
if ($this->shouldSkip($node)) {
return null;
}
// unreliable count of arguments
$functionLikeReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node);
if ($functionLikeReflection instanceof UnionTypeMethodReflection) {
return null;
}
if ($functionLikeReflection === null) {
return null;
}
if ($functionLikeReflection instanceof PhpMethodReflection) {
if ($functionLikeReflection->isAbstract()) {
return null;
}
$classReflection = $functionLikeReflection->getDeclaringClass();
if ($classReflection->isInterface()) {
return null;
}
}
$maximumAllowedParameterCount = $this->resolveMaximumAllowedParameterCount($functionLikeReflection);
if ($node->isFirstClassCallable()) {
return null;
}
if ($this->shouldSkipFunctionReflection($functionLikeReflection)) {
return null;
}
$numberOfArguments = \count($node->getRawArgs());
if ($numberOfArguments <= $maximumAllowedParameterCount) {
return null;
}
for ($i = $maximumAllowedParameterCount; $i <= $numberOfArguments; ++$i) {
unset($node->args[$i]);
}
return $node;
}
/**
* @param \PHPStan\Reflection\MethodReflection|\PHPStan\Reflection\FunctionReflection $reflection
*/
private function shouldSkipFunctionReflection($reflection) : bool
{
if ($reflection instanceof FunctionReflection) {
$fileName = (string) $reflection->getFileName();
if (\strpos($fileName, 'phpstan.phar') !== \false) {
return \true;
}
}
if ($reflection instanceof MethodReflection) {
$classReflection = $reflection->getDeclaringClass();
$fileName = (string) $classReflection->getFileName();
if (\strpos($fileName, 'phpstan.phar') !== \false) {
return \true;
}
}
return \false;
}
/**
* @param \PhpParser\Node\Expr\FuncCall|\PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $call
*/
private function shouldSkip($call) : bool
{
if ($call->args === []) {
return \true;
}
if ($call instanceof StaticCall) {
if (!$call->class instanceof Name) {
return \true;
}
if ($this->isName($call->class, ObjectReference::PARENT)) {
return \true;
}
}
return $this->variadicAnalyzer->hasVariadicParameters($call);
}
/**
* @param \PHPStan\Reflection\MethodReflection|\PHPStan\Reflection\FunctionReflection $functionLikeReflection
*/
private function resolveMaximumAllowedParameterCount($functionLikeReflection) : int
{
$parameterCounts = [0];
foreach ($functionLikeReflection->getVariants() as $variant) {
$parameterCounts[] = \count($variant->getParameters());
}
return \max($parameterCounts);
}
}