-
-
Notifications
You must be signed in to change notification settings - Fork 688
/
NewlineBeforeNewAssignSetRector.php
161 lines (158 loc) · 5.19 KB
/
NewlineBeforeNewAssignSetRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
<?php
declare (strict_types=1);
namespace Rector\CodingStyle\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Expression;
use PhpParser\Node\Stmt\Function_;
use PhpParser\Node\Stmt\Nop;
use Rector\Contract\Rector\HTMLAverseRectorInterface;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodingStyle\Rector\ClassMethod\NewlineBeforeNewAssignSetRector\NewlineBeforeNewAssignSetRectorTest
*/
final class NewlineBeforeNewAssignSetRector extends AbstractRector implements HTMLAverseRectorInterface
{
private ?string $previousStmtVariableName = null;
private ?string $previousPreviousStmtVariableName = null;
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Add extra space before new assign set', [new CodeSample(<<<'CODE_SAMPLE'
final class SomeClass
{
public function run()
{
$value = new Value;
$value->setValue(5);
$value2 = new Value;
$value2->setValue(1);
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
final class SomeClass
{
public function run()
{
$value = new Value;
$value->setValue(5);
$value2 = new Value;
$value2->setValue(1);
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [ClassMethod::class, Function_::class, Closure::class];
}
/**
* @param ClassMethod|Function_|Closure $node
*/
public function refactor(Node $node) : ?Node
{
// skip methods with no bodies (e.g interface methods)
if ($node->stmts === null) {
return null;
}
$this->reset();
$hasChanged = \false;
$newStmts = [];
foreach ($node->stmts as $key => $stmt) {
$currentStmtVariableName = $this->resolveCurrentStmtVariableName($stmt);
if ($this->shouldAddEmptyLine($currentStmtVariableName, $node, $key)) {
$hasChanged = \true;
// insert newline before stmt
$newStmts[] = new Nop();
}
$newStmts[] = $stmt;
$this->previousPreviousStmtVariableName = $this->previousStmtVariableName;
$this->previousStmtVariableName = $currentStmtVariableName;
}
$node->stmts = $newStmts;
return $hasChanged ? $node : null;
}
private function reset() : void
{
$this->previousStmtVariableName = null;
$this->previousPreviousStmtVariableName = null;
}
private function resolveCurrentStmtVariableName(Stmt $stmt) : ?string
{
if (!$stmt instanceof Expression) {
return null;
}
$stmtExpr = $stmt->expr;
if ($stmtExpr instanceof Assign || $stmtExpr instanceof MethodCall) {
if ($this->shouldSkipLeftVariable($stmtExpr)) {
return null;
}
if (!$stmtExpr->var instanceof MethodCall && !$stmtExpr->var instanceof StaticCall) {
return $this->getName($stmtExpr->var);
}
}
return null;
}
/**
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Stmt\Function_|\PhpParser\Node\Expr\Closure $node
*/
private function shouldAddEmptyLine(?string $currentStmtVariableName, $node, int $key) : bool
{
if (!$this->isNewVariableThanBefore($currentStmtVariableName)) {
return \false;
}
// this is already empty line before
return !$this->isPrecededByEmptyLine($node, $key);
}
/**
* @param \PhpParser\Node\Expr\Assign|\PhpParser\Node\Expr\MethodCall $node
*/
private function shouldSkipLeftVariable($node) : bool
{
if (!$node->var instanceof Variable) {
return \false;
}
// local method call
return $this->nodeNameResolver->isName($node->var, 'this');
}
private function isNewVariableThanBefore(?string $currentStmtVariableName) : bool
{
if ($this->previousPreviousStmtVariableName === null) {
return \false;
}
if ($this->previousStmtVariableName === null) {
return \false;
}
if ($currentStmtVariableName === null) {
return \false;
}
if ($this->previousStmtVariableName !== $this->previousPreviousStmtVariableName) {
return \false;
}
return $this->previousStmtVariableName !== $currentStmtVariableName;
}
/**
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Stmt\Function_|\PhpParser\Node\Expr\Closure $node
*/
private function isPrecededByEmptyLine($node, int $key) : bool
{
if ($node->stmts === null) {
return \false;
}
$previousNode = $node->stmts[$key - 1];
$currentNode = $node->stmts[$key];
return \abs($currentNode->getStartLine() - $previousNode->getStartLine()) >= 2;
}
}