-
-
Notifications
You must be signed in to change notification settings - Fork 688
/
MakeInheritedMethodVisibilitySameAsParentRector.php
153 lines (149 loc) · 4.85 KB
/
MakeInheritedMethodVisibilitySameAsParentRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
<?php
declare (strict_types=1);
namespace Rector\CodingStyle\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\Reflection\ClassReflection;
use Rector\Privatization\NodeManipulator\VisibilityManipulator;
use Rector\Rector\AbstractRector;
use Rector\Reflection\ReflectionResolver;
use ReflectionMethod;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector\MakeInheritedMethodVisibilitySameAsParentRectorTest
*/
final class MakeInheritedMethodVisibilitySameAsParentRector extends AbstractRector
{
/**
* @readonly
*/
private VisibilityManipulator $visibilityManipulator;
/**
* @readonly
*/
private ReflectionResolver $reflectionResolver;
public function __construct(VisibilityManipulator $visibilityManipulator, ReflectionResolver $reflectionResolver)
{
$this->visibilityManipulator = $visibilityManipulator;
$this->reflectionResolver = $reflectionResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Make method visibility same as parent one', [new CodeSample(<<<'CODE_SAMPLE'
class ChildClass extends ParentClass
{
public function run()
{
}
}
class ParentClass
{
protected function run()
{
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class ChildClass extends ParentClass
{
protected function run()
{
}
}
class ParentClass
{
protected function run()
{
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node) : ?Node
{
$classReflection = $this->reflectionResolver->resolveClassReflection($node);
if (!$classReflection instanceof ClassReflection) {
return null;
}
if ($classReflection->isAnonymous()) {
return null;
}
$parentClassReflections = $classReflection->getParents();
if ($parentClassReflections === []) {
return null;
}
$hasChanged = \false;
$interfaces = $classReflection->getInterfaces();
foreach ($node->getMethods() as $classMethod) {
if ($classMethod->isMagic()) {
continue;
}
/** @var string $methodName */
$methodName = $this->getName($classMethod->name);
if ($classMethod->isPublic()) {
foreach ($interfaces as $interface) {
if ($interface->hasNativeMethod($methodName)) {
continue 2;
}
}
}
foreach ($parentClassReflections as $parentClassReflection) {
$nativeClassReflection = $parentClassReflection->getNativeReflection();
// the class reflection above takes also @method annotations into an account
if (!$nativeClassReflection->hasMethod($methodName)) {
continue;
}
/** @var ReflectionMethod $parentReflectionMethod */
$parentReflectionMethod = $nativeClassReflection->getMethod($methodName);
if ($this->isClassMethodCompatibleWithParentReflectionMethod($classMethod, $parentReflectionMethod)) {
continue 2;
}
$this->changeClassMethodVisibilityBasedOnReflectionMethod($classMethod, $parentReflectionMethod);
$hasChanged = \true;
}
}
if ($hasChanged) {
return $node;
}
return null;
}
private function isClassMethodCompatibleWithParentReflectionMethod(ClassMethod $classMethod, ReflectionMethod $reflectionMethod) : bool
{
if ($reflectionMethod->isPublic() && $classMethod->isPublic()) {
return \true;
}
if ($reflectionMethod->isProtected() && $classMethod->isProtected()) {
return \true;
}
if (!$reflectionMethod->isPrivate()) {
return \false;
}
return $classMethod->isPrivate();
}
private function changeClassMethodVisibilityBasedOnReflectionMethod(ClassMethod $classMethod, ReflectionMethod $reflectionMethod) : void
{
if ($reflectionMethod->isPublic()) {
$this->visibilityManipulator->makePublic($classMethod);
return;
}
if ($reflectionMethod->isProtected()) {
$this->visibilityManipulator->makeProtected($classMethod);
return;
}
if ($reflectionMethod->isPrivate()) {
$this->visibilityManipulator->makePrivate($classMethod);
}
}
}