-
-
Notifications
You must be signed in to change notification settings - Fork 688
/
ArrayKeyExistsTernaryThenValueToCoalescingRector.php
104 lines (102 loc) · 2.92 KB
/
ArrayKeyExistsTernaryThenValueToCoalescingRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
<?php
declare (strict_types=1);
namespace Rector\CodeQuality\Rector\Ternary;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\ArrayDimFetch;
use PhpParser\Node\Expr\BinaryOp\Coalesce;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Ternary;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\Ternary\ArrayKeyExistsTernaryThenValueToCoalescingRector\ArrayKeyExistsTernaryThenValueToCoalescingRectorTest
*/
final class ArrayKeyExistsTernaryThenValueToCoalescingRector extends AbstractRector
{
/**
* @readonly
*/
private ValueResolver $valueResolver;
public function __construct(ValueResolver $valueResolver)
{
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Change array_key_exists() ternary to coalescing', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run($values, $keyToMatch)
{
$result = array_key_exists($keyToMatch, $values) ? $values[$keyToMatch] : null;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run($values, $keyToMatch)
{
$result = $values[$keyToMatch] ?? null;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Ternary::class];
}
/**
* @param Ternary $node
*/
public function refactor(Node $node) : ?Node
{
if (!$node->cond instanceof FuncCall) {
return null;
}
if (!$this->isName($node->cond, 'array_key_exists')) {
return null;
}
if (!$node->if instanceof ArrayDimFetch) {
return null;
}
if (!$this->areArrayKeysExistsArgsMatchingDimFetch($node->cond, $node->if)) {
return null;
}
if (!$this->valueResolver->isNull($node->else)) {
return null;
}
return new Coalesce($node->if, $node->else);
}
/**
* Equals if:
*
* array_key_exists($key, $values);
* =
* $values[$key]
*/
private function areArrayKeysExistsArgsMatchingDimFetch(FuncCall $funcCall, ArrayDimFetch $arrayDimFetch) : bool
{
$firstArg = $funcCall->args[0];
if (!$firstArg instanceof Arg) {
return \false;
}
$keyExpr = $firstArg->value;
$secondArg = $funcCall->args[1];
if (!$secondArg instanceof Arg) {
return \false;
}
$valuesExpr = $secondArg->value;
if (!$this->nodeComparator->areNodesEqual($arrayDimFetch->var, $valuesExpr)) {
return \false;
}
return $this->nodeComparator->areNodesEqual($arrayDimFetch->dim, $keyExpr);
}
}