-
-
Notifications
You must be signed in to change notification settings - Fork 688
/
SimplifyConditionsRector.php
109 lines (107 loc) · 3.8 KB
/
SimplifyConditionsRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
<?php
declare (strict_types=1);
namespace Rector\CodeQuality\Rector\Identical;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\BinaryOp\BooleanOr;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BooleanNot;
use Rector\NodeManipulator\BinaryOpManipulator;
use Rector\Php71\ValueObject\TwoNodeMatch;
use Rector\PhpParser\Node\AssignAndBinaryMap;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\Identical\SimplifyConditionsRector\SimplifyConditionsRectorTest
*/
final class SimplifyConditionsRector extends AbstractRector
{
/**
* @readonly
*/
private AssignAndBinaryMap $assignAndBinaryMap;
/**
* @readonly
*/
private BinaryOpManipulator $binaryOpManipulator;
/**
* @readonly
*/
private ValueResolver $valueResolver;
public function __construct(AssignAndBinaryMap $assignAndBinaryMap, BinaryOpManipulator $binaryOpManipulator, ValueResolver $valueResolver)
{
$this->assignAndBinaryMap = $assignAndBinaryMap;
$this->binaryOpManipulator = $binaryOpManipulator;
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Simplify conditions', [new CodeSample("if (! (\$foo !== 'bar')) {...", "if (\$foo === 'bar') {...")]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [BooleanNot::class, Identical::class];
}
/**
* @param BooleanNot|Identical $node
*/
public function refactor(Node $node) : ?Node
{
if ($node instanceof BooleanNot) {
return $this->processBooleanNot($node);
}
return $this->processIdenticalAndNotIdentical($node);
}
private function processBooleanNot(BooleanNot $booleanNot) : ?Node
{
if (!$booleanNot->expr instanceof BinaryOp) {
return null;
}
if ($this->shouldSkip($booleanNot->expr)) {
return null;
}
return $this->createInversedBooleanOp($booleanNot->expr);
}
private function processIdenticalAndNotIdentical(Identical $identical) : ?Node
{
$twoNodeMatch = $this->binaryOpManipulator->matchFirstAndSecondConditionNode($identical, static fn(Node $node): bool => $node instanceof Identical || $node instanceof NotIdentical, fn(Node $node): bool => $node instanceof Expr && $this->valueResolver->isTrueOrFalse($node));
if (!$twoNodeMatch instanceof TwoNodeMatch) {
return $twoNodeMatch;
}
/** @var Identical|NotIdentical $firstExpr */
$firstExpr = $twoNodeMatch->getFirstExpr();
$otherExpr = $twoNodeMatch->getSecondExpr();
if ($this->valueResolver->isFalse($otherExpr)) {
return $this->createInversedBooleanOp($firstExpr);
}
return $firstExpr;
}
/**
* Skip too nested binary || binary > binary combinations
*/
private function shouldSkip(BinaryOp $binaryOp) : bool
{
if ($binaryOp instanceof BooleanOr) {
return \true;
}
if ($binaryOp->left instanceof BinaryOp) {
return \true;
}
return $binaryOp->right instanceof BinaryOp;
}
private function createInversedBooleanOp(BinaryOp $binaryOp) : ?BinaryOp
{
$inversedBinaryClass = $this->assignAndBinaryMap->getInversed($binaryOp);
if ($inversedBinaryClass === null) {
return null;
}
return new $inversedBinaryClass($binaryOp->left, $binaryOp->right);
}
}